Skip to content

add filter and filterMap types to Effect #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zerobias merged 1 commit into from
Aug 13, 2020
Merged

add filter and filterMap types to Effect #376

zerobias merged 1 commit into from
Aug 13, 2020

Conversation

@sergeysova
Copy link
Member

@sergeysova sergeysova commented Aug 13, 2020 •
edited
Loading 

const fx = createEffect().use(() => null)

const d = fx.filter({
  fn(a) {
    return a > 0
  },
})

d.watch(console.log)

fx(5)
fx(0)
fx(1)

https://share.effector.dev/G34PZ7qF

@sergeysova sergeysova requested a review from zerobias August 13, 2020 16:08
doasync
doasync reviewed Aug 13, 2020
View reviewed changes
packages/effector/index.d.ts
inFlight: Store<number>
watch(watcher: (payload: Params) => any): Subscription
filter(config: {fn(payload: Params): boolean}): Event<Params>
filterMap<T>(fn: (payload: Params) => T | undefined): Event<T>
Copy link
Member

@doasync doasync Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

@doasync doasync Aug 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you have skipped the first overload?

Copy link
Member Author

@sergeysova sergeysova Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is forgotten.

@zerobias
Copy link
Member

zerobias commented Aug 13, 2020

👍

@zerobias zerobias merged commit 7b35a71 into master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doasync doasync doasync left review comments

@zerobias zerobias Awaiting requested review from zerobias

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sergeysova @zerobias @doasync