Update TypeScript sample typings #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://effector-git-fork-abliarsar-fix-155.zerobias.now.sh |
zerobias
requested changes
Jul 24, 2019
Member
zerobias
left a comment
There was a problem hiding this comment.
Can make do this without breaking changes?
At the moment, method overloads are defined by explicit iterating through all the combinations, we can add a few more
Contributor
Author
|
@zerobias, can you review it again? It shouldn't be breaking now. |
Member
|
Big thanks! That’s going to be a major improvement of sample user experience 👍👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #155
Probably should be a breaking change, because sample now accepts types of source and clock instead of their values