Skip to content

Improve sample type errors #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
zerobias wants to merge 26 commits into
base: improve-type-tests
Choose a base branch
from
Draft

Improve sample type errors #1139

zerobias wants to merge 26 commits into from

Conversation

@zerobias
Copy link
Member

@zerobias zerobias commented Aug 24, 2024 •
edited
Loading

The goal is to remove custom errors entirely and provide explicit errors near wrong units only. This PR is already good improvement and can be merged at any moment, but there is still a work to do
image

@zerobias zerobias mentioned this pull request Aug 24, 2024
Draft
@zerobias zerobias force-pushed the improve-sample-type-errors branch 7 times, most recently from 90f71da to 41ab07f Compare September 2, 2024 09:44
@zerobias zerobias force-pushed the improve-sample-type-errors branch 3 times, most recently from 89b49eb to f520728 Compare September 2, 2024 18:01
@zerobias zerobias force-pushed the improve-sample-type-errors branch 2 times, most recently from b3fa2b4 to f421b91 Compare September 12, 2024 21:32
@zerobias zerobias force-pushed the improve-sample-type-errors branch 2 times, most recently from e6ffe66 to fc5e42a Compare September 15, 2024 13:16
@zerobias zerobias force-pushed the improve-sample-type-errors branch from c894bfd to 9c02c73 Compare September 19, 2024 18:58
@zerobias zerobias force-pushed the improve-sample-type-errors branch 6 times, most recently from ad6a352 to de4b772 Compare October 3, 2024 16:37
@zerobias zerobias force-pushed the improve-sample-type-errors branch 3 times, most recently from 9f118ce to d8fa80d Compare October 25, 2024 16:15
zerobias added 23 commits November 8, 2024 18:31
@zerobias
Implement const generics (HUGE typecheck qualitiy improvement)
d0050c3
@zerobias
Implement native error messages for clock
73370be
@zerobias
Implement native error messages for filter unit type
0f0f5fa
@zerobias
Improve clock error message
0f187ce
@zerobias
Implement native error messages for derived units in target
34dbb1c
@zerobias
Improve fn error types for narrow target
ca3a90d
@zerobias
Improve source error types for target wider than source
62d5919
@zerobias
Add support for cross-mismatch type errors in clock target mode
d672950
@zerobias
Implement native error messages for clock with Boolean filter
6c898dc
@zerobias
Remove unused types
a53ab71
@zerobias
Implement precise sample config fields validation
8f55b31
@zerobias
Remove old validation errors
d5b3607
@zerobias
Improve target type errors for case with fn
0847dbd
@zerobias
Simplify sample generics, reuse config creator type
7f429e7
@zerobias
Dont infer fn generics early
efd1f13
@zerobias
Dont infer main FN generic early (typecheck quality may vary)
226c5fe
@zerobias
Dont infer filter generic early
1117a0c
@zerobias
Improve generics and prepend type issues
692957c
@zerobias
Add support for non-inline arrays in clock and target
11c2284
@zerobias
Remove forgotten thru method from types
9a0da32
@zerobias
Precise fn return type based on each target (HUGE typecheck quality i…
b9f1f53 
…mprovement)
@zerobias
Fix implicit any in filter infer case
c902a59
@zerobias
Remove dead branches
64943ea
@zerobias zerobias force-pushed the improve-sample-type-errors branch from d8fa80d to 64943ea Compare November 8, 2024 13:48
@zerobias
Fix one generic case; remove NonFalsy support
04f85d0 
Support for `filter: Boolean` is dropped for type `false | 0 | 0n`, but it rarely fruitful anyway
@zerobias zerobias mentioned this pull request Nov 11, 2024
Open
This was referenced Mar 25, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zerobias