Skip to content

[babel-plugin] Add an option to disable transforming Domain methods #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zerobias merged 4 commits into from
Jul 2, 2025
Merged

[babel-plugin] Add an option to disable transforming Domain methods #1059

zerobias merged 4 commits into from
Jul 2, 2025

Conversation

@kireevmp
Copy link
Contributor

@kireevmp kireevmp commented Mar 16, 2024 •
edited
Loading

As proposed in #1052, this PR adds an option to disable transforming unit creator methods on Domain

  • Add an option to the plugin
  • Unit tests
  • Write docs with motivation and usage

Closes #1052

@netlify
Copy link

netlify bot commented Mar 16, 2024 •
edited
Loading

👷 Deploy request for effector-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 25d1b15

@kireevmp kireevmp force-pushed the feature/babel-no-transform-legacy-methods branch from 31b08e4 to 8f711be Compare March 16, 2024 19:15
@kireevmp kireevmp marked this pull request as ready for review March 16, 2024 19:16
@kireevmp kireevmp force-pushed the feature/babel-no-transform-legacy-methods branch from 8f711be to 25d1b15 Compare May 27, 2024 16:36
@zerobias zerobias added this to the effector Neowise 24 milestone Mar 23, 2025
@sergeysova sergeysova requested a review from zerobias March 24, 2025 10:43
@sergeysova sergeysova added enhancement New feature or request effector/babel-plugin babel plugin labels Mar 24, 2025
@kireevmp
Copy link
Contributor Author

kireevmp commented Jun 30, 2025

Closing due to low interest in this PR, but happy to revive it and rebase this on #1267 @zerobias

@kireevmp kireevmp closed this Jun 30, 2025
@zerobias zerobias reopened this Jul 2, 2025
@zerobias
Copy link
Member

zerobias commented Jul 2, 2025

Hi, sorry for long waiting, this is very important feature, but it 2024 we thought that new major release will be soon, but looks like there will be at least a few more minor releases, will release it soon

@zerobias zerobias removed this from the effector Neowise 24 milestone Jul 2, 2025
@zerobias zerobias merged commit 15c90e4 into effector:master Jul 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zerobias zerobias zerobias approved these changes

Assignees

No one assigned

Labels

effector/babel-plugin babel plugin enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[babel-plugin] Add an option to disable transforming Domain methods

3 participants

@kireevmp @zerobias @sergeysova