Add flowCollectionPadding toString option#420
Merged
eemeli merged 1 commit intoeemeli:masterfrom Nov 1, 2022
Merged
Conversation
eemeli
requested changes
Oct 27, 2022
Owner
eemeli
left a comment
There was a problem hiding this comment.
Realistically, the single-line padding will always be either 0 or 1 spaces, so we should make it a boolean rather than a number.
e8ef18b to
d0cd9e7
Compare
flowCollectionPadding toString option, fixes #419flowCollectionPadding toString option
eemeli
approved these changes
Oct 27, 2022
Owner
eemeli
left a comment
There was a problem hiding this comment.
Looks good! The API docs could do with a slight tweak, though.
d0cd9e7 to
b330dfd
Compare
b330dfd to
027ac53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this is a reasonable coverage on docs, tests, and mirrors how other calculated spacings work (e.g. indents). Happy to revise based on feedback. 👋