feature: adding dnsreponoc as source #120
Merged
edoardottt merged 1 commit intoedoardottt:develfrom Oct 25, 2023
iamshreeram:feature-dnsreponoc
Merged
feature: adding dnsreponoc as source #120edoardottt merged 1 commit intoedoardottt:develfrom iamshreeram:feature-dnsreponoc
edoardottt merged 1 commit intoedoardottt:develfrom
iamshreeram:feature-dnsreponoc
Conversation
Contributor
Author
|
@edoardottt , I've used goquery to scrape the table from html as this is already being used as indirect dependency. Do you want me to update the |
Owner
|
Have you tried it? If I use this code in a function like this: func main() {
output := DNSRepoNocSubdomains("google.com", false)
for elem := range output {
fmt.Println(elem)
}
}I get as result: |
edoardottt
requested changes
Oct 25, 2023
Owner
edoardottt
left a comment
There was a problem hiding this comment.
there's something wrong in the scrape function, see my comment
Contributor
Author
|
@edoardottt , That is interesting. Coz, The standalone code (with this logic) is pulling 151 subdomains of google.
|
Owner
|
Sorry @iamshreeram, my fault. There was clearly an error in the for loop :/ |
Owner
is it necessary? idk. try to execute |
Contributor
Author
|
Sure Np. Btw, Do you think, if this PR need any more changes to address #110 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is to address #110