Skip to content

feature: adding dnsreponoc as source #120

Merged
edoardottt merged 1 commit intoedoardottt:develfrom
iamshreeram:feature-dnsreponoc
Oct 25, 2023
Merged

feature: adding dnsreponoc as source #120
edoardottt merged 1 commit intoedoardottt:develfrom
iamshreeram:feature-dnsreponoc

Conversation

@iamshreeram
Copy link
Copy Markdown
Contributor

This is to address #110

@auto-assign auto-assign bot requested a review from edoardottt October 24, 2023 23:19
@iamshreeram
Copy link
Copy Markdown
Contributor Author

iamshreeram commented Oct 24, 2023

@edoardottt , I've used goquery to scrape the table from html as this is already being used as indirect dependency.

Do you want me to update the go.mod as well?

@edoardottt edoardottt linked an issue Oct 25, 2023 that may be closed by this pull request
@edoardottt
Copy link
Copy Markdown
Owner

Have you tried it?

If I use this code in a function like this:

func main() {
	output := DNSRepoNocSubdomains("google.com", false)
	for elem := range output {
		fmt.Println(elem)
	}
}

I get as result:

Pulling data from Dns Repo Noc
0
1
2
3
4
5
6
...
149
150

Copy link
Copy Markdown
Owner

@edoardottt edoardottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's something wrong in the scrape function, see my comment

@iamshreeram
Copy link
Copy Markdown
Contributor Author

@edoardottt , That is interesting. Coz, The standalone code (with this logic) is pulling 151 subdomains of google.

code.zip

image

@edoardottt
Copy link
Copy Markdown
Owner

Sorry @iamshreeram, my fault. There was clearly an error in the for loop :/

@edoardottt edoardottt self-requested a review October 25, 2023 10:08
Copy link
Copy Markdown
Owner

@edoardottt edoardottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edoardottt
Copy link
Copy Markdown
Owner

Do you want me to update the go.mod as well?

is it necessary? idk. try to execute go mod tidy

@iamshreeram
Copy link
Copy Markdown
Contributor Author

Sure Np. Btw, Do you think, if this PR need any more changes to address #110 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dnsrepo.noc.org as subdomain source

2 participants