Update settings window#244
Merged
Merged
Conversation
Split the settings window into panels for easier option organization, some strings are hardcoded for now, will be updated afterwards
Also add interface to automatically handle elements synchronization
For now all the elements that used the normal ``Resize`` were updated
There are some side effects caused by letting the element be resized by the engine
If rebooted in game, the envirionemtn would've kept the previous position, thus having a bigger/smaller rect not matching the size needed for the dpi scaling, and thus having the elements wrongly placed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revamp the settings window by using the new windowed tab widget, split the various options in subcategories to keep them more organized.
Now every config that before was only modifiable my manually editing the config file should be changeable in game as well.
Probably will need other cleanups down the line to make things look nicer, but for now it's enough to merge.