Maintain aspect ratio of currently displayed card no matter what dimensions the window has#237
Maintain aspect ratio of currently displayed card no matter what dimensions the window has#237Larikk wants to merge 7 commits into
Conversation
|
After thinking about it a bit I think it could be better to make Alternatively another resize function could be added which only caps the width. That one could be used for the cards in the deck and searchlist in a future change So the questions basically are:
|
|
Okay, regarding the issue with the exit button I have found the culprit: The size/position is changed outside of game.cpp like at Line 81 in 85c29a7 This is super obvious in hindsight but I (wrongly) assumed due to its sheer size and complexity that game.cpp handles everything GUI related. Some possible fixes:
I'm honestly in favor of option 3. Even if you ignore dynamically calculated bounds like in this case it still seems like a headache to me that you have to keep the hardcoded values for the bounds of GUI elements in |
Most users play edopro on widescreen monitors under which the currently displayed card appears wide/stretched out. This change attempts to fix that.
Comparisons (top image shows current behaviour, bottom one adjusted behaviour):
Window at ~1080p:


Window at half of ~1080p:


The positions of buttons in deck edit, duels and replays were adjusted.
Known issues: