Skip to content

fix: pick fixes from main branch#215

Merged
judehung merged 2 commits intoedgexfoundry:odessafrom
FelixTing:pick-fix-from-main
Oct 15, 2025
Merged

fix: pick fixes from main branch#215
judehung merged 2 commits intoedgexfoundry:odessafrom
FelixTing:pick-fix-from-main

Conversation

@FelixTing
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-configuration/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

weichou1229 and others added 2 commits October 14, 2025 14:12
Convert the message payload value to string for comparison, because the value retrieved from the Keeper is always a string, but the value from the message payload may be either a string, bool, or float.

Signed-off-by: bruce <weichou1229@gmail.com>
Signed-off-by: FelixTing <felix@iotechsys.com>
@FelixTing FelixTing requested a review from judehung October 14, 2025 11:10
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.38%. Comparing base (9f0e051) to head (20a6aeb).

Files with missing lines Patch % Lines
internal/pkg/keeper/client.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           odessa     #215   +/-   ##
=======================================
  Coverage   39.38%   39.38%           
=======================================
  Files           7        7           
  Lines         523      523           
=======================================
  Hits          206      206           
  Misses        298      298           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@judehung judehung merged commit bd45a35 into edgexfoundry:odessa Oct 15, 2025
3 checks passed
@FelixTing FelixTing deleted the pick-fix-from-main branch October 15, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants