Skip to content

feat!: Apply provision watcher model changes#4471

Merged
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
weichou1229:apply-pw-changes
Mar 24, 2023
Merged

feat!: Apply provision watcher model changes#4471
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
weichou1229:apply-pw-changes

Conversation

@weichou1229
Copy link
Member

@weichou1229 weichou1229 commented Mar 22, 2023 •
edited
Loading

BREAKING CHANGE: Apply provision watcher model changes

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) not impact
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) open issue for doc Document the summary of data model changes in v3 edgex-docs#985

Testing Instructions

Implementation based on the core-contracts PR edgexfoundry/go-mod-core-contracts#820

  • Run core service, and device service and enable the discovery
  • Send discovery API and check the discovered device is added to the metadata service

New Dependency Instructions (If applicable)

@github-advanced-security
Copy link

github-advanced-security bot commented Mar 22, 2023

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@cloudxxx8
Copy link
Member

cloudxxx8 commented Mar 23, 2023

@weichou1229 edgexfoundry/go-mod-core-contracts#820 is merged. please upgrade the module.

@weichou1229
feat!: Apply provision watcher model changes
83672c7 
BREAKING CHANGE: Apply provision watcher model changes

Signed-off-by: bruce <weichou1229@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #4471 (83672c7) into main (e99ed67) will not change coverage.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4471   +/-   ##
=======================================
  Coverage   41.73%   41.73%           
=======================================
  Files         106      106           
  Lines        9749     9749           
=======================================
  Hits         4069     4069           
  Misses       5334     5334           
  Partials      346      346
Impacted Files Coverage Δ
internal/core/metadata/application/notify.go 38.94% <0.00%> (ø)
...rnal/core/metadata/application/provisionwatcher.go 0.00% <0.00%> (ø)
...ernal/pkg/infrastructure/redis/provisionwatcher.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cloudxxx8
cloudxxx8 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 32e4cad into edgexfoundry:main Mar 24, 2023
@cloudxxx8
Copy link
Member

cloudxxx8 commented Mar 24, 2023

@cherrycl please make the proper change for TAF

@weichou1229 weichou1229 deleted the apply-pw-changes branch March 24, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloudxxx8 cloudxxx8 cloudxxx8 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weichou1229 @cloudxxx8 @codecov-commenter