Skip to content

feat!: Switch UOM API to YAML format#4462

Merged
lenny-goodell merged 1 commit intoedgexfoundry:mainfrom
weichou1229:issue-4441-2
Mar 21, 2023
Merged

feat!: Switch UOM API to YAML format#4462
lenny-goodell merged 1 commit intoedgexfoundry:mainfrom
weichou1229:issue-4441-2

Conversation

@weichou1229
Copy link
Member

@weichou1229 weichou1229 commented Mar 21, 2023

BREAKING CHANGE: It was decided in Minnesota planning that all TOML files would be change to be YAML format.

Close #4441

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) not impact
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  • Run unit test
  • Test the uom API
curl 'http://localhost:59881/api/v2/uom' --header 'Accept: application/x-yaml'

New Dependency Instructions (If applicable)

@weichou1229
feat!: Switch UOM API to YAML format
f24b784 
BREAKING CHANGE: It was decided in Minnesota planning that all TOML files would be change to be YAML format.

Close edgexfoundry#4441

Signed-off-by: bruce <weichou1229@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-advanced-security
Copy link

github-advanced-security bot commented Mar 21, 2023

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

cloudxxx8
cloudxxx8 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 requested a review from lenny-goodell March 21, 2023 02:36
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Merging #4462 (f24b784) into main (fe5feeb) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4462   +/-   ##
=======================================
  Coverage   41.74%   41.74%           
=======================================
  Files         106      106           
  Lines        9747     9747           
=======================================
  Hits         4069     4069           
  Misses       5332     5332           
  Partials      346      346
Impacted Files Coverage Δ
internal/core/metadata/controller/http/uom.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lenny-goodell
lenny-goodell approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 39fc096 into edgexfoundry:main Mar 21, 2023
@weichou1229 weichou1229 deleted the issue-4441-2 branch March 22, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloudxxx8 cloudxxx8 cloudxxx8 approved these changes

@lenny-goodell lenny-goodell lenny-goodell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Core Metadata] Switch UOM file to YAML format

4 participants

@weichou1229 @codecov-commenter @cloudxxx8 @lenny-goodell