refactor(security)!: Change to camelCase args for secrets-config proxy tls#4433
refactor(security)!: Change to camelCase args for secrets-config proxy tls#4433bnevis-i merged 1 commit intoedgexfoundry:mainfrom bnevis-i:cli-consistency
Conversation
|
|
||
| Upon completion, for token-type == "jwt", the command outputs the autogenerated _key_ for the **id** command above. | ||
| This value must be used during later construction of the JWT. | ||
| vault_token=$(curl -ks "http://localhost:8200/v1/auth/userpass/login/${username}" -d "{\"password\":\"${password}\"}" | jq -r '.auth.client_token') |
There was a problem hiding this comment.
what happens if this fails, the developer can re-run or restart the service?
There was a problem hiding this comment.
Vault is always running. Additional runs of secrets-config adduser will set a new password on the account at which point need to go through the login/generate jwt process again.
There was a problem hiding this comment.
could you add what you said into docs to help developers in this case? thanks!
There was a problem hiding this comment.
Added that as well as other documentation.
…y tls BREAKING CHANGE: To be consistent with other secrets-config sub-commands, the tls command will now accept camelCase command line arguments. Also fixes issue with -h option resulting in an error in addition to printing help. Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Which would you rather I keep? Would it be OK to just put a README.md to point to the docs, or should I delete it entirely? |
I think the README.md can go entirely in favor of the docs. Keeping a link from README.md to docs isn't necessary IMO as it also adds maintenance burden for the versioning of the URL. |
Ok. I'll merge this since I need to copy it over to docs, then follow up with a remove later. |
BREAKING CHANGE: To be consistent with other secrets-config sub-commands, the tls command will now accept camelCase command line arguments. Also fixes issue with -h option resulting in an error in addition to printing help.
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
For help, use secrets-config (command) (subcommand) -h
tls subcommand works as usual, with exception of breaking change to argument casing.
New Dependency Instructions (If applicable)