Skip to content

feat(data)!: update Add Event REST endpoint#4368

Merged
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
chr1shung:bump-contracts
Feb 17, 2023
Merged

feat(data)!: update Add Event REST endpoint#4368
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
chr1shung:bump-contracts

Conversation

@chr1shung
Copy link

BREAKING CHANGE: POST Event RSET endpoint will become /event/{serviceName}/{profileName}/{deviceName}/{sourceName}

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

BREAKING CHANGE: POST Event RSET endpoint will become
/event/{serviceName}/{profileName}/{deviceName}/{sourceName}

Signed-off-by: Chris Hung <chris@iotechsys.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #4368 (c961a5e) into main (8bb7416) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #4368   +/-   ##
=======================================
  Coverage   43.70%   43.70%           
=======================================
  Files         116      116           
  Lines       10715    10715           
=======================================
  Hits         4683     4683           
  Misses       5612     5612           
  Partials      420      420           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cloudxxx8 cloudxxx8 merged commit 653358d into edgexfoundry:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants