feat: remove device callback calls#4269
Merged
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom Jan 30, 2023
chr1shung:issue-4235
Merged
feat: remove device callback calls#4269cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom chr1shung:issue-4235
cloudxxx8 merged 1 commit intoedgexfoundry:mainfrom
chr1shung:issue-4235
Conversation
device service is subscribing device system events and removing REST device callbacks in edgexfoundry/device-sdk-go#1259 The calls to the REST callback can be removed closes #4235 Signed-off-by: Chris Hung <chris@iotechsys.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #4269 +/- ##
==========================================
+ Coverage 42.93% 43.19% +0.26%
==========================================
Files 119 119
Lines 10888 10822 -66
==========================================
Hits 4675 4675
+ Misses 5801 5735 -66
Partials 412 412
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lenny-goodell
approved these changes
Jan 10, 2023
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device service is subscribing device system events and removing REST device callbacks in edgexfoundry/device-sdk-go#1259 The calls to the REST callback can be removed
closes #4235
Signed-off-by: Chris Hung chris@iotechsys.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)