feat(snap): Add core-common-config-bootstrapper#4347
Conversation
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
|
recheck |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #4347 +/- ##
=======================================
Coverage 43.54% 43.54%
=======================================
Files 116 116
Lines 10732 10732
=======================================
Hits 4673 4673
Misses 5640 5640
Partials 419 419 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ejlee3
left a comment
There was a problem hiding this comment.
need to add dependencies for services that rely on core-common-config-bootstrapper for any services that use common configuration - core-command, core-data, core-metadata, support-notifications, support-scheduler, etc
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
- correct `configDir` path - add input of `configProvider` Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
|
@MonicaisHer, @farshidtz , can we take this out of Draft now se it can be merged? |
|
@lenny-intel Thank you. I still need to address some open topics for example: I will let you know as soon as everything has been resolved. |
@MonicaisHer , That will happen in the retry loop waiting for Common Config to be ready. Is it causing the service to exit? |
Yes, the services exit immediately after that error and give up after several quick restarts. See the logs here, as an artifact: https://github.com/edgexfoundry/edgex-go/actions/runs/4175670981 This PR is still missing the needed startup ordering that was mentioned in #4347 (review) |
@farshidtz , @MonicaisHer , the core/support services are failing because core-common-config-bootstrapper never ran. core-common-config-bootstrapper should be in the list, but isn't: |
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
3fddbef to
a0b2d94
Compare
849fbee to
4b96645
Compare
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
move core-common-config-bootstrapper to core services group Co-authored-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com> Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
4b96645 to
35a5f4b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
A component called "core-common-config-bootstrapper" has been added through PR #4292, which pushes the common configuration to the Config Provider. This PR adds it into snap packaging.
Additionally, the command-line flags have been updated by this PR to use preferred options for apps.
Signed-off-by: Mengyi Wang mengyi.wang@canonical.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)