refactor!: Change Database configuration to be single instance#4308
Merged
lenny-goodell merged 2 commits intoedgexfoundry:mainfrom Jan 26, 2023
Merged
refactor!: Change Database configuration to be single instance#4308lenny-goodell merged 2 commits intoedgexfoundry:mainfrom
lenny-goodell merged 2 commits intoedgexfoundry:mainfrom
Conversation
BREAKING CHANGE: Database configuation for services has changed from a Map to a single instance closes edgexfoundry#4131 Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Merged
3 tasks
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
|
Kudos, SonarCloud Quality Gate passed!
|
jim-wang-yutsung
approved these changes
Jan 25, 2023
bnevis-i
reviewed
Jan 25, 2023
Collaborator
bnevis-i
left a comment
There was a problem hiding this comment.
Look ok, but honestly I don't think a lot of these services need "database" anymore as much as they need "messagebus"
Member
Author
@bnevis-i , the MessageBus doesn't provide any persistence. ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Database configuration for services has changed from a Map to a single instance
closes #4131
Signed-off-by: Leonard Goodell leonard.goodell@intel.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)TBD
Testing Instructions
run
make dockerusing this branchrun
make run ds-virtual devfrom compose builder from edgexfoundry/edgex-compose#328Verify all service bootstrap successfully
New Dependency Instructions (If applicable)