feat: initial core common config bootstrapper and config implementation#4292
Merged
lenny-goodell merged 3 commits intoedgexfoundry:mainfrom Jan 19, 2023
Merged
Conversation
lenny-goodell
requested changes
Jan 18, 2023
lenny-goodell
requested changes
Jan 18, 2023
Member
|
Need to add |
77a4f98 to
bcd6a00
Compare
faa0fff to
fd3e1e1
Compare
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
bnevis-i
reviewed
Jan 19, 2023
bnevis-i
reviewed
Jan 19, 2023
bnevis-i
reviewed
Jan 19, 2023
bnevis-i
reviewed
Jan 19, 2023
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
fd3e1e1 to
4537962
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bnevis-i
approved these changes
Jan 19, 2023
Collaborator
bnevis-i
left a comment
There was a problem hiding this comment.
Approved despite that fact that this component doesn't do anything yet.
jim-wang-yutsung
approved these changes
Jan 19, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Signed-off-by: Elizabeth J Lee elizabeth.j.lee@intel.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
make common-configto ensure the binary buildsexport EDGEX_SECURITY_SECRET_STORE=false; ./cmd/core-common-config-bootstrapper/core-common-config-bootstrappermake dockerexport EDGEX_SECURITY_SECRET_STORE=truemake run devcmd/core-common-config-bootstrapperby runningsudo ./core-common-config-bootstrapperNew Dependency Instructions (If applicable)