Skip to content

feat: initial core common config bootstrapper and config implementation#4292

Merged
lenny-goodell merged 3 commits intoedgexfoundry:mainfrom
ejlee3:common-config-skeleton
Jan 19, 2023
Merged

feat: initial core common config bootstrapper and config implementation#4292
lenny-goodell merged 3 commits intoedgexfoundry:mainfrom
ejlee3:common-config-skeleton

Conversation

@ejlee3
Copy link
Copy Markdown
Member

@ejlee3 ejlee3 commented Jan 18, 2023

Signed-off-by: Elizabeth J Lee elizabeth.j.lee@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) - initial structure for new service
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) - new documentation will need to be added for common config

Testing Instructions

  1. run make common-config to ensure the binary builds
  2. run in non-secure mode export EDGEX_SECURITY_SECRET_STORE=false; ./cmd/core-common-config-bootstrapper/core-common-config-bootstrapper
  3. build the docker images make docker
  4. run in secure mode export EDGEX_SECURITY_SECRET_STORE=true
  5. use compose builder and run make run dev
  6. run the core common config bootstrapper from cmd/core-common-config-bootstrapper by running sudo ./core-common-config-bootstrapper

New Dependency Instructions (If applicable)

Comment thread cmd/core-common-config-bootstrapper/Dockerfile Outdated
Comment thread cmd/core-common-config-bootstrapper/main.go Outdated
Comment thread cmd/core-common-config-bootstrapper/res/configuration.yml
Comment thread internal/core/common_config/README.md Outdated
Comment thread internal/core/common_config/README.md Outdated
Comment thread internal/core/common_config/main.go Outdated
Comment thread internal/core/common_config/main.go Outdated
Comment thread Makefile Outdated
Comment thread cmd/core-common-config-bootstrapper/Dockerfile Outdated
Comment thread internal/core/common_config/main.go Outdated
@lenny-goodell
Copy link
Copy Markdown
Member

@ejlee3 ejlee3 force-pushed the common-config-skeleton branch from 77a4f98 to bcd6a00 Compare January 18, 2023 23:13
@ejlee3 ejlee3 changed the title feat(common-config): initial service and config feat: initial core common config bootstrapper and config implementation Jan 18, 2023
@ejlee3 ejlee3 force-pushed the common-config-skeleton branch 2 times, most recently from faa0fff to fd3e1e1 Compare January 18, 2023 23:20
@ejlee3 ejlee3 marked this pull request as ready for review January 18, 2023 23:53
Comment thread cmd/core-common-config-bootstrapper/Dockerfile Outdated
Comment thread cmd/core-common-config-bootstrapper/res/configuration.yaml Outdated
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
Comment thread cmd/core-common-config-bootstrapper/entrypoint.sh Outdated
Comment thread cmd/core-common-config-bootstrapper/res/configuration.yaml Outdated
Comment thread internal/core/common_config/README.md Outdated
Comment thread internal/core/common_config/main.go Outdated
Signed-off-by: Elizabeth J Lee <elizabeth.j.lee@intel.com>
@ejlee3 ejlee3 force-pushed the common-config-skeleton branch from fd3e1e1 to 4537962 Compare January 19, 2023 18:00
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved despite that fact that this component doesn't do anything yet.

@lenny-goodell lenny-goodell merged commit 9f6c2d1 into edgexfoundry:main Jan 19, 2023
@lenny-goodell lenny-goodell linked an issue Jan 23, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core Common Config Bootstrapper - Create Service Skeleton

4 participants