refactor(snap): environment variable usage and const definitions#4207
Merged
farshidtz merged 3 commits intoedgexfoundry:mainfrom Oct 25, 2022
Merged
refactor(snap): environment variable usage and const definitions#4207farshidtz merged 3 commits intoedgexfoundry:mainfrom
farshidtz merged 3 commits intoedgexfoundry:mainfrom
Conversation
…itions - Switch to use the hooks/env package for snap envs - Move constants and lists specific to this snap from hooks library to this package - Refactor service lists to have consistent style Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
…d constants, fix list Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #4207 +/- ##
=======================================
Coverage 43.25% 43.25%
=======================================
Files 125 125
Lines 11098 11098
=======================================
Hits 4800 4800
Misses 5886 5886
Partials 412 412 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MonicaisHer
reviewed
Oct 24, 2022
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
|
Kudos, SonarCloud Quality Gate passed!
|
MonicaisHer
approved these changes
Oct 25, 2022
Contributor
There was a problem hiding this comment.
@farshidtz Thank you, looks good! I ran the edgexfoundry test with local build snap:
$ LOCAL_SNAP=edgexfoundry_2.3.0-dev.99_amd64.snap FULL_CONFIG_TEST=true go test -p 1 --count=1 ./test/suites/edgexfoundry
ok edgex-snap-testing/test/suites/edgexfoundry 135.528s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Farshid Tavakolizadeh farshid.tavakolizadeh@canonical.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Mostly refactoring. The review could do a side-by-side diff comparison. The snap tests in this PR has good coverage for the affected code. To run the snap test on a pre-built snap locally, run the following from the top level directory of edgex-snap-testing repo:
$ SERVICE_CHANNEL=edge/pr-4207 FULL_CONFIG_TEST=true go test -p 1 --count=1 ./test/suites/edgexfoundry ok edgex-snap-testing/test/suites/edgexfoundry 438.634sNew Dependency Instructions (If applicable)