feat(command): command request from external MQTT to internal MessageBus#4153
Merged
lenny-goodell merged 3 commits intoedgexfoundry:mainfrom Sep 21, 2022
chr1shung:issue-4075
Merged
feat(command): command request from external MQTT to internal MessageBus#4153lenny-goodell merged 3 commits intoedgexfoundry:mainfrom chr1shung:issue-4075
lenny-goodell merged 3 commits intoedgexfoundry:mainfrom
chr1shung:issue-4075
Conversation
core-command subscribes to 3rd-party command requests and publishes to the appropriate device service via messaging Signed-off-by: Chris Hung <chris@iotechsys.com>
Codecov Report
@@ Coverage Diff @@
## main #4153 +/- ##
==========================================
+ Coverage 43.85% 43.90% +0.04%
==========================================
Files 123 123
Lines 10899 10954 +55
==========================================
+ Hits 4780 4809 +29
- Misses 5710 5730 +20
- Partials 409 415 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lenny-goodell
requested changes
Sep 15, 2022
Signed-off-by: Chris Hung <chris@iotechsys.com>
Member
lenny-goodell
left a comment
There was a problem hiding this comment.
Look good, once we decide how to handle the errorResponse when we don't have the data to send it properly.
1. failed to JSON decoding request MessageEnvelope 2. invalid request topic scheme 3. invalid request command method Signed-off-by: Chris Hung <chris@iotechsys.com>
lenny-goodell
requested changes
Sep 20, 2022
Member
|
LGTM, once on minor change above is completed. |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








core-command subscribes to 3rd-party command requests and publishes to the appropriate device service via messaging
Signed-off-by: Chris Hung chris@iotechsys.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
MESSAGEQUEUE_REQUIRED=trueenvironment variablePSUBSCRIBE edgex.command.request.*inrediscontainer to subscribe to the forwarded requestedgex/command/request/<device>/<command>/<method> topic. For example send following message toedgex/command/request/Random-Boolean-Device/Bool/get`:{ "CorrelationID": "14a42ea6-c394-41c3-8bcd-a29b9f5e6835", "ApiVersion": "v2", "RequestId": "e6e8a2f4-eb14-4649-9e2b-175247911369", "ContentType": "application/json", "QueryParams": { "ds-pushevent":"yes", "ds-returnevent":"yes" } }rediscontainer:New Dependency Instructions (If applicable)