feat(command): 3rd party command query via messaging#4135
Merged
lenny-goodell merged 2 commits intoedgexfoundry:mainfrom Sep 9, 2022
chr1shung:issue-4078
Merged
feat(command): 3rd party command query via messaging#4135lenny-goodell merged 2 commits intoedgexfoundry:mainfrom chr1shung:issue-4078
lenny-goodell merged 2 commits intoedgexfoundry:mainfrom
chr1shung:issue-4078
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4135 +/- ##
=======================================
Coverage 43.65% 43.65%
=======================================
Files 121 121
Lines 10691 10691
=======================================
Hits 4667 4667
Misses 5624 5624
Partials 400 400 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lenny-goodell
requested changes
Sep 6, 2022
Member
lenny-goodell
left a comment
There was a problem hiding this comment.
Missing unit tests.
You will need to run mockery against Client at https://github.com/eclipse/paho.mqtt.golang/tree/v1.4.1
and then copy the generated file into new mocks folder under the messaging folder.
lenny-goodell
requested changes
Sep 7, 2022
lenny-goodell
requested changes
Sep 8, 2022
added 2 commits
September 9, 2022 06:33
allow core command to subscribe query request and publish commands response to 3rd party via external MQTT Signed-off-by: Chris Hung <chris@iotechsys.com>
Signed-off-by: Chris Hung <chris@iotechsys.com>
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow core command to subscribe query request and publish
commands response to 3rd party requester with external MQTT
fix #4078
Signed-off-by: Chris Hung chris@iotechsys.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
MESSAGEQUEUE_REQUIRED=trueenvironment variableedgex/commandquery/request/<devicename>topic.For example send following message to
edgex/commandquery/request/Random-Boolean-Device:{ "correlationID": "14a42ea6-c394-41c3-8bcd-a29b9f5e6835", "apiVersion": "v2", "requestId": "e6e8a2f4-eb14-4649-9e2b-175247911369", }{ "ReceivedTopic": "edgex/commandquery/request/Random-Boolean-Device", "CorrelationID": "14a42ea6-c394-41c3-8bcd-a29b9f5e6835", "ApiVersion": "v2", "RequestID": "e6e8a2f4-eb14-4649-9e2b-175247911369", "ErrorCode": 0, "Payload": "eyJkZXZpY2VOYW1lIjoiUmFuZG9tLUJvb2xlYW4tRGV2aWNlIiwicHJvZmlsZU5hbWUiOiJSYW5kb20tQm9vbGVhbi1EZXZpY2UiLCJjb3JlQ29tbWFuZHMiOlt7Im5hbWUiOiJXcml0ZUJvb2xWYWx1ZSIsInNldCI6dHJ1ZSwicGF0aCI6Ii9hcGkvdjIvZGV2aWNlL25hbWUvUmFuZG9tLUJvb2xlYW4tRGV2aWNlL1dyaXRlQm9vbFZhbHVlIiwidXJsIjoiaHR0cDovL2VkZ2V4LWNvcmUtY29tbWFuZDo1OTg4MiIsInBhcmFtZXRlcnMiOlt7InJlc291cmNlTmFtZSI6IkJvb2wiLCJ2YWx1ZVR5cGUiOiJCb29sIn0seyJyZXNvdXJjZU5hbWUiOiJFbmFibGVSYW5kb21pemF0aW9uX0Jvb2wiLCJ2YWx1ZVR5cGUiOiJCb29sIn1dfSx7Im5hbWUiOiJXcml0ZUJvb2xBcnJheVZhbHVlIiwic2V0Ijp0cnVlLCJwYXRoIjoiL2FwaS92Mi9kZXZpY2UvbmFtZS9SYW5kb20tQm9vbGVhbi1EZXZpY2UvV3JpdGVCb29sQXJyYXlWYWx1ZSIsInVybCI6Imh0dHA6Ly9lZGdleC1jb3JlLWNvbW1hbmQ6NTk4ODIiLCJwYXJhbWV0ZXJzIjpbeyJyZXNvdXJjZU5hbWUiOiJCb29sQXJyYXkiLCJ2YWx1ZVR5cGUiOiJCb29sQXJyYXkifSx7InJlc291cmNlTmFtZSI6IkVuYWJsZVJhbmRvbWl6YXRpb25fQm9vbEFycmF5IiwidmFsdWVUeXBlIjoiQm9vbCJ9XX0seyJuYW1lIjoiQm9vbCIsImdldCI6dHJ1ZSwic2V0Ijp0cnVlLCJwYXRoIjoiL2FwaS92Mi9kZXZpY2UvbmFtZS9SYW5kb20tQm9vbGVhbi1EZXZpY2UvQm9vbCIsInVybCI6Imh0dHA6Ly9lZGdleC1jb3JlLWNvbW1hbmQ6NTk4ODIiLCJwYXJhbWV0ZXJzIjpbeyJyZXNvdXJjZU5hbWUiOiJCb29sIiwidmFsdWVUeXBlIjoiQm9vbCJ9XX0seyJuYW1lIjoiQm9vbEFycmF5IiwiZ2V0Ijp0cnVlLCJzZXQiOnRydWUsInBhdGgiOiIvYXBpL3YyL2RldmljZS9uYW1lL1JhbmRvbS1Cb29sZWFuLURldmljZS9Cb29sQXJyYXkiLCJ1cmwiOiJodHRwOi8vZWRnZXgtY29yZS1jb21tYW5kOjU5ODgyIiwicGFyYW1ldGVycyI6W3sicmVzb3VyY2VOYW1lIjoiQm9vbEFycmF5IiwidmFsdWVUeXBlIjoiQm9vbEFycmF5In1dfV19", "ContentType": "application/json", "QueryParams": null }New Dependency Instructions (If applicable)