Skip to content

fix: Security services' bootstrap handler return true/false properly#4107

Merged
jim-wang-yutsung merged 5 commits intoedgexfoundry:mainfrom
lenny-goodell:bootstrap-handler-return-value
Jul 29, 2022
Merged

fix: Security services' bootstrap handler return true/false properly#4107
jim-wang-yutsung merged 5 commits intoedgexfoundry:mainfrom
lenny-goodell:bootstrap-handler-return-value

Conversation

@lenny-goodell
Copy link
Copy Markdown
Member

@lenny-goodell lenny-goodell commented Jul 28, 2022

Also updated to latest go mods which exposed this issue.

fixe #4106

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

fix: File Token Provider handler return true/false properly
2b937e7 
Also updated to latest go mods which exposed this issue.

fixe edgexfoundry#4106

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell linked an issue Jul 28, 2022 that may be closed by this pull request
Security services bootstrap handlers incorrectly returns false in success case #4106
Closed
jim-wang-yutsung
jim-wang-yutsung previously approved these changes Jul 28, 2022
View reviewed changes
Copy link
Copy Markdown

@jim-wang-yutsung jim-wang-yutsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bnevis-i
bnevis-i previously approved these changes Jul 28, 2022
View reviewed changes
fix: Proper retun value from bootstrap handlers
1d703b0 
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell dismissed stale reviews from bnevis-i and jim-wang-yutsung via 1d703b0 July 28, 2022 23:00
@lenny-goodell lenny-goodell changed the title fix: File Token Provider handler return true/false properly fix: Security services' bootstrap handler return true/false properly Jul 28, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #4107 (2b937e7) into main (85bfaaf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 2b937e7 differs from pull request most recent head 1d703b0. Consider uploading reports for the commit 1d703b0 to get more accurate results

@@            Coverage Diff             @@
##             main    #4107      +/-   ##
==========================================
- Coverage   47.39%   47.38%   -0.01%     
==========================================
  Files         114      114              
  Lines        9869     9870       +1     
==========================================
  Hits         4677     4677              
- Misses       4803     4804       +1     
  Partials      389      389
Impacted Files Coverage Δ
internal/security/fileprovider/init.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85bfaaf...1d703b0. Read the comment docs.

fix: config and spiffy token provider
6471cb0 
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
fix: Switch one shot services to use RunAndReturnWaitGroup
1a6c226 
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
farshidtz
farshidtz reviewed Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hunting down the issue @lenny-intel and @jim-wang-intel.

Comment thread internal/security/config/main.go Outdated
jim-wang-yutsung
jim-wang-yutsung previously approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown

@jim-wang-yutsung jim-wang-yutsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fix: Removed unneed explist ignore of return parameters
59a6535 
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jim-wang-yutsung jim-wang-yutsung merged commit 4804402 into edgexfoundry:main Jul 29, 2022
@lenny-goodell lenny-goodell deleted the bootstrap-handler-return-value branch December 12, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnevis-i bnevis-i bnevis-i approved these changes

@jim-wang-yutsung jim-wang-yutsung jim-wang-yutsung approved these changes

@farshidtz farshidtz Awaiting requested review from farshidtz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Security services bootstrap handlers incorrectly returns false in success case

5 participants

@lenny-goodell @codecov-commenter @farshidtz @bnevis-i @jim-wang-yutsung