fix: security-secretstore-setup volume init semantics#4092
Merged
vli11 merged 3 commits intoedgexfoundry:mainfrom Jul 14, 2022
Merged
fix: security-secretstore-setup volume init semantics#4092vli11 merged 3 commits intoedgexfoundry:mainfrom
vli11 merged 3 commits intoedgexfoundry:mainfrom
Conversation
fixes: edgexfoundry#3852 Signed-off-by: Valina Li <valina.li@intel.com>
bnevis-i
requested changes
Jul 14, 2022
Collaborator
bnevis-i
left a comment
There was a problem hiding this comment.
Both of these commands should have been MOVED from the Dockerfile to the entrypoint script
&& mkdir -p /vault/config/assets \
&& chown -Rh 100:1000 /vault/
Signed-off-by: Valina Li <valina.li@intel.com>
jim-wang-yutsung
requested changes
Jul 14, 2022
Comment on lines
52
to
+55
| # Setup the entry point script, create token dir, and assign perms | ||
| COPY --from=builder /edgex-go/cmd/security-secretstore-setup/entrypoint.sh /usr/local/bin/ | ||
| RUN chmod +x /usr/local/bin/entrypoint.sh \ | ||
| && ln -s /usr/local/bin/entrypoint.sh / \ | ||
| && mkdir -p /vault/config/assets \ | ||
| && chown -Rh 100:1000 /vault/ | ||
| && ln -s /usr/local/bin/entrypoint.sh / |
There was a problem hiding this comment.
Please update the comment in line 52 to fit the real implementation
Signed-off-by: Valina Li <valina.li@intel.com>
|
Kudos, SonarCloud Quality Gate passed!
|
bnevis-i
approved these changes
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #3852
Signed-off-by: Valina Li valina.li@intel.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)