fix: StreamURI values not parsed in external rtsp mode#295
Merged
presatish merged 1 commit intoedgexfoundry:mainfrom Sep 27, 2023
Merged
Conversation
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #295 +/- ##
=====================================
Coverage 4.75% 4.75%
=====================================
Files 8 8
Lines 1305 1305
=====================================
Hits 62 62
Misses 1243 1243
|
Contributor
|
Validation looks good. Get stream URI gives ip address of RTSP server address as expected. Find attached screenshot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Get code from this pr branch & latest edgex compose main branch
Go to device usb service cmd/res folder, and update configuation.yaml file with below settings
RtspServerMode set to "external"
RtspServerHostName set to remote ip address of system where rtsp server running
Build usb docker image locally with updated configuration file
Go to edgex compose/compose builder, and update add-device-usb-camera.yaml file to use local usb image
from compose builder, run 'make run no-secty ds-usb-camera' - this wills start edgex services and device usb services, also discovers and adds usb cameras to edgex
Execute some generic api like camera info, ensure camera is accessible and it works correctly
Execute ger stream uri, API
Expected behavior: Should give rtsp stream uri with remote ip
New Dependency Instructions (If applicable)
Closes #288