Skip to content

feat!: Remove snap packaging#303

Merged
farshidtz merged 1 commit intoedgexfoundry:mainfrom
farshidtz:remove-snap
Oct 24, 2023
Merged

feat!: Remove snap packaging#303
farshidtz merged 1 commit intoedgexfoundry:mainfrom
farshidtz:remove-snap

Conversation

@farshidtz
Copy link
Copy Markdown
Member

Removing snap packaging in accordance with the TSC vote to discontinue release of snaps as of v3.1.

Note
The v3.1.0-dev snap fails since #268. The path was made configurable in #270, but it was never overridden in the snap, as described in here.

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #303 (5fd3013) into main (bda52fb) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@          Coverage Diff          @@
##            main    #303   +/-   ##
=====================================
  Coverage   4.75%   4.75%           
=====================================
  Files          8       8           
  Lines       1305    1305           
=====================================
  Hits          62      62           
  Misses      1243    1243           

Copy link
Copy Markdown
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farshidtz farshidtz merged commit 03955ee into edgexfoundry:main Oct 24, 2023
@farshidtz farshidtz deleted the remove-snap branch October 24, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants