Skip to content

fix: none mode being seen as invalid option to RtspServerMode#285

Merged
ajcasagrande merged 1 commit intoedgexfoundry:mainfrom
EdgeX-Camera-Management:fix-none-mode
Sep 18, 2023
Merged

fix: none mode being seen as invalid option to RtspServerMode#285
ajcasagrande merged 1 commit intoedgexfoundry:mainfrom
EdgeX-Camera-Management:fix-none-mode

Conversation

@ajcasagrande
Copy link
Copy Markdown
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #285 (77c2fff) into main (df8fee0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@          Coverage Diff          @@
##            main    #285   +/-   ##
=====================================
  Coverage   4.79%   4.79%           
=====================================
  Files          8       8           
  Lines       1293    1292    -1     
=====================================
  Hits          62      62           
+ Misses      1231    1230    -1     
Files Changed Coverage Δ
internal/driver/driver.go 3.27% <0.00%> (+<0.01%) ⬆️

Copy link
Copy Markdown
Contributor

@presatish presatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@seanohair22 seanohair22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ajcasagrande ajcasagrande merged commit 3411f34 into edgexfoundry:main Sep 18, 2023
@ajcasagrande ajcasagrande deleted the fix-none-mode branch September 18, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants