Skip to content

refactor: use PatchDevice calls instead of UpdateDevice#267

Merged
ajcasagrande merged 1 commit intoedgexfoundry:mainfrom
EdgeX-Camera-Management:patch-device
Aug 15, 2023
Merged

refactor: use PatchDevice calls instead of UpdateDevice#267
ajcasagrande merged 1 commit intoedgexfoundry:mainfrom
EdgeX-Camera-Management:patch-device

Conversation

@ajcasagrande
Copy link
Copy Markdown
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • [N/A] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  • Run device service as normal and add usb cameras
  • Change the /dev/videoX order of cameras by unplugging re-plugging (may require multiple devices)
  • Re-run discovery, or RefreshExistingDevicePaths
  • Ensure updated device paths are present in core-metadata
  • Run unit tests

New Dependency Instructions (If applicable)

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
@vyshali-chitikeshi
Copy link
Copy Markdown
Contributor

Verified that camera device paths updated in metadata after unplugging and re plugging to different USB ports. Tested with multiple USB cameras and tried multiple times changing ports. Tested using get all cameras API command.
also verified that device paths in metadata matches with v412-ctl command.

Copy link
Copy Markdown
Contributor

@presatish presatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajcasagrande ajcasagrande merged commit b4dc3cb into edgexfoundry:main Aug 15, 2023
@ajcasagrande ajcasagrande deleted the patch-device branch August 15, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants