fix(snap): Refactor to avoid conflicts with readonly config provider directory#194
Merged
farshidtz merged 2 commits intoedgexfoundry:mainfrom Mar 23, 2023
Merged
Conversation
d609568 to
7bed824
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #194 +/- ##
=====================================
Coverage 3.05% 3.05%
=====================================
Files 6 6
Lines 687 687
=====================================
Hits 21 21
Misses 666 666 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
farshidtz
requested changes
Mar 22, 2023
…directory Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
7bed824 to
bf4bb03
Compare
Signed-off-by: Mengyi Wang <mengyi.wang@canonical.com>
farshidtz
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes changes to incorporate the following fixes:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
For testing instructions, please refer to edgexfoundry/device-mqtt-go#535
New Dependency Instructions (If applicable)