refactor(snap): Refactor and upgrade to edgex-snap-hooks v3#129
Merged
farshidtz merged 3 commits intoedgexfoundry:mainfrom Jan 17, 2023
Merged
refactor(snap): Refactor and upgrade to edgex-snap-hooks v3#129farshidtz merged 3 commits intoedgexfoundry:mainfrom
farshidtz merged 3 commits intoedgexfoundry:mainfrom
Conversation
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
- Remove enabling of app options since it is enabled by default in the library - Other code refactoring Signed-off-by: Farshid Tavakolizadeh <farshid.tavakolizadeh@canonical.com>
MonicaisHer
approved these changes
Jan 17, 2023
Contributor
MonicaisHer
left a comment
There was a problem hiding this comment.
@farshidtz Thank you, looks good!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to edgex-snap-hooks v3:
Signed-off-by: Farshid Tavakolizadeh farshid.tavakolizadeh@canonical.com
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-virtual-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)