Skip to content

refactor!: Replace internal topics from config with new constants#1316

Merged
lenny-goodell merged 1 commit intoedgexfoundry:mainfrom
lenny-goodell:topic-constants
Feb 15, 2023
Merged

refactor!: Replace internal topics from config with new constants#1316
lenny-goodell merged 1 commit intoedgexfoundry:mainfrom
lenny-goodell:topic-constants

Conversation

@lenny-goodell
Copy link
Member

BREAKING CHANGE: Internal topics no longer configurable, except the base topic.

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) Existing suffice
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    TBD

Testing Instructions

Run non-secure EdgeX stack
Build and run device simple locally (kill and restart for hybrid mode)
Verify the log has on following start-up :

msg="Subscribing to command requests on topic: edgex/device/command/request/device-simple/#"
msg="Responses to command requests will be published on topic: edgex/response/device-simple/<requestId>"
"Subscribing to System Events on topic: edgex/system-events/core-metadata/+/+/device-simple/#

The verify the debug messages when publishing are:

published to MessageBus on topic: edgex/events/device-simple/Simple-Device/Simple-Device01/Switch

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell added enhancement New feature or request tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds breaking-change labels Feb 13, 2023
@lenny-goodell lenny-goodell added this to the Minnesota milestone Feb 13, 2023
@lenny-goodell lenny-goodell marked this pull request as draft February 13, 2023 19:52
@lenny-goodell lenny-goodell force-pushed the topic-constants branch 7 times, most recently from 37bf1e7 to 1cfa41c Compare February 15, 2023 00:53
@lenny-goodell lenny-goodell marked this pull request as ready for review February 15, 2023 16:03
BREAKING CHANGE: Internal topics no longer configurable, except the base topic.

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Copy link

@chr1shung chr1shung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit cf150bd into edgexfoundry:main Feb 15, 2023
@lenny-goodell lenny-goodell deleted the topic-constants branch February 15, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change enhancement New feature or request tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants