Remove ancient check for .DollarNames#111
Merged
eddelbuettel merged 2 commits intoeddelbuettel:masterfrom Feb 8, 2026
Merged
Conversation
eddelbuettel
reviewed
Feb 8, 2026
| export( "P", "readProtoFiles", "readProtoFiles2", "resetDescriptorPool", "asMessage" ) | ||
|
|
||
| if( exists( ".DollarNames", asNamespace("utils") ) ) importFrom( utils, .DollarNames ) | ||
| importFrom( utils, .DollarNames ) |
Owner
There was a problem hiding this comment.
I'd do this without whitespace at either end but can clean that another time...
Owner
There was a problem hiding this comment.
Ah, but they were there before. Old style of my then co-author.
eddelbuettel
reviewed
Feb 8, 2026
Owner
eddelbuettel
left a comment
There was a problem hiding this comment.
Nice (and somewhat funny!) catch
Owner
|
I had a similarly old check here that I had removed on Jan 15 (but somehow not committed, now done) which checked for R (>= 3.0.0). And yeah, that too is a given now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.DollarNameswas added in 2009:r-devel/r-svn@6fe54a7
(found this as one of 2 CRAN packages using
exists()in the NAMESPACE)