Skip to content

Added dot product from Annoy c++ source#78

Merged
eddelbuettel merged 2 commits intoeddelbuettel:masterfrom
benjamin-james:master
Aug 4, 2024
Merged

Added dot product from Annoy c++ source#78
eddelbuettel merged 2 commits intoeddelbuettel:masterfrom
benjamin-james:master

Conversation

@benjamin-james
Copy link
Contributor

I noticed Annoy has the dot product distance and wrote a quick drop-in interface. I don't know if this breaks things downstream but wanted to see if there was interest in adding this to the API.

Copy link
Owner

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good!

Would you mind adding a ChangeLog entry (date/name/email with two spaces between them, tab to '*' describing file changed and how, one can group as needed).

@eddelbuettel
Copy link
Owner

I don't know if this breaks things downstream

I am not too concerned: this only adds new functionality in a way that should not affect existing functionality.

I noticed Annoy has the dot product distance

I will admit to having missed that.

@benjamin-james
Copy link
Contributor Author

This looks very good!

Would you mind adding a ChangeLog entry (date/name/email with two spaces between them, tab to '*' describing file changed and how, one can group as needed).

Perfect, just pushed commit.

@eddelbuettel eddelbuettel merged commit 5c10b71 into eddelbuettel:master Aug 4, 2024
@eddelbuettel
Copy link
Owner

Turns out we forgot one microaspect of an added alias for the Rd file. I just took care of that in 6446e7b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants