fix: root $ref resolving #2472
Merged
fix: root $ref resolving #2472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Reworks schema resolving to be able to handle $refs in the root of the JSON Schema. Also adds circle reference detection, preventing runtime crashes. Fixes eclipsesource#2471 Also adjusts core ava settings to fix incorrect source mappings.
cc466d3 to
3cbf84e
Compare
lucas-koehler
approved these changes
Jul 25, 2025
Contributor
lucas-koehler
left a comment
There was a problem hiding this comment.
LGTM, thanks for this extensive improvement of the resolving algorithm :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks schema resolving to be able to handle $refs in the root of the JSON Schema. Also adds circle reference detection, preventing runtime crashes.
Fixes #2471
Also adjusts core ava settings to fix incorrect source mappings.