Skip to content

deps: Update to Vuetify ^3.9 and Vue ^3.5 #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucas-koehler merged 4 commits into from
Aug 1, 2025
Merged

deps: Update to Vuetify ^3.9 and Vue ^3.5 #2468

lucas-koehler merged 4 commits into from
Aug 1, 2025

Conversation

@lucas-koehler
Copy link
Contributor

@lucas-koehler lucas-koehler commented Jul 18, 2025 •
edited
Loading

  • Update to latest Vuetify 3.9.0
  • Update to latest Vue 3.5.17
  • Update Vue peer dependency to ^3.5.0
  • Fix imports for Vuetify promoted from labs
  • Fix typings for update events in Vuetify DateControlRenderer
  • Regenerate Vuetify test snapshots to fit changes in Vuetify (e.g. setting values in HTML element)
  • Add visualViewport mock for Vuetify tests as this seems to be needed after dependency update
  • In JsonForms.vue explicitly type provided state as JsonFormsSubStates to avoid TS7056

@netlify
Copy link

netlify bot commented Jul 18, 2025 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit b2dfc6c
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/688a1f2c7761c60008ea8432
😎 Deploy Preview https://deploy-preview-2468--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lucas-koehler lucas-koehler force-pushed the issues/2434-vuertify-version-update branch from 0b0d38a to 09e4bf1 Compare July 18, 2025 14:37
@coveralls
Copy link

coveralls commented Jul 18, 2025 •
edited
Loading

Coverage Status

coverage: 82.573% (-0.1%) from 82.707%
when pulling b2dfc6c on issues/2434-vuertify-version-update
into e814b0a on master.

@lucas-koehler
deps: Update to Vuetify ^3.9 and Vue ^3.5
cfeca5a 
- Update to latest Vuetify 3.9.0
- Update to latest Vue 3.5.17
- Update Vue peer dependency to ^3.5.0
- Update Vite to latest 5.x version ^5.4.19
- Fix imports for Vuetify promoted from labs
- Fix typings for update events in Vuetify DateControlRenderer
- Regenerate Vuetify test snapshots to fit changes in Vuetify (e.g. setting values in HTML element)
- Add visualViewport mock for Vuetify tests as this seems to be needed after dependency update
- In JsonForms.vue explicitly type provided state as `JsonFormsSubStates` to avoid TS7056
@lucas-koehler lucas-koehler force-pushed the issues/2434-vuertify-version-update branch from 09e4bf1 to cfeca5a Compare July 18, 2025 14:47
@lucas-koehler lucas-koehler linked an issue Jul 18, 2025 that may be closed by this pull request
Support Vuetify ^3.9.0 and Vue ^3.5.0 #2434
Closed
@lucas-koehler lucas-koehler mentioned this pull request Jul 18, 2025
Closed
@lucas-koehler lucas-koehler requested a review from sdirix July 18, 2025 14:54
sdirix
sdirix requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can successfully build and use the Vue Vuetify demo application. However it breaks for me for the components which were moved from lab to the regular lib. Likely they changed behavior a bit.

@lucas-koehler
fix: Vuetify TimeControlRenderer to autoclose after selecting smalles…
774db39 
…t unit
@lucas-koehler
fix: Vuetify DateTimeControlRenderer to close on smallest unit selection
0186817 
auto close on minute/second selection.
No longer closes on day selection as there is not event for day selection
@lucas-koehler
Copy link
Contributor Author

lucas-koehler commented Jul 30, 2025

Hi @sdirix , thanks for the review and valuable feedback. I adapted the following renderers:

  • TimeControlRenderer: Close selector after the smallest shown unit (i.e. minutes or seconds) is chosen. This should reflect the previous behavior
  • DateTimeControlRenderer: Close selector after the smallest shown unit (i.e. minutes or seconds) is chosen. This differs from the previous behavior in regard to day selection. Previously, the selector also auto-closed after selecting a day. This is no longer the case. The reason being that there is no event to listen to changes to the day value. Thus, this would require more complicated logic. However, I think the new behavior is fine as it follows the same logic as the pure date or time controls: It closes after selecting the smallest unit.
  • NumberControlRenderer: Set the precision in addition to the step: With this, decimals are correctly shown. The behavior should now be the same as before the Vuetify upgrade
    • I also added a step with scientific notation to the numbers example to be able to see the behavior for this in the example

@lucas-koehler lucas-koehler requested a review from sdirix July 30, 2025 13:31
@lucas-koehler
fix: Vuetify number control to show decimals by setting precision
b2dfc6c 
Also adapts the numbers example to use a step with scientific notation number
@lucas-koehler lucas-koehler force-pushed the issues/2434-vuertify-version-update branch from 94f6309 to b2dfc6c Compare July 30, 2025 13:33
sdirix
sdirix approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported regressions are fixed 👍 Thanks!

@lucas-koehler lucas-koehler merged commit e71a70a into master Aug 1, 2025
13 of 14 checks passed
@lucas-koehler lucas-koehler deleted the issues/2434-vuertify-version-update branch August 1, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Vuetify ^3.9.0 and Vue ^3.5.0

4 participants

@lucas-koehler @coveralls @sdirix