feat(core): Add validate function based rule condition #2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new rule condition `ValidateFunctionCondition` using a given `validate` function to evaluate the condition result. This allows using arbitrary custom logic to evaluate condition results. This facilitates not using schema-conditions to be able to only use one pre-compiled AJV for the data schema at a later stage.
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sdirix
reviewed
Apr 23, 2025
Contributor
Author
|
@sdirix I now added the additional context information being available without breaking API as described here: #2441 (comment) |
sdirix
requested changes
May 20, 2025
Member
sdirix
left a comment
There was a problem hiding this comment.
Works for me, but there is an issue with the example
8da42f4 to
f502634
Compare
Contributor
Author
|
@sdirix Thanks for the review and suggestion :) The example should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new rule condition
ValidateFunctionConditionusing a givenvalidatefunction to evaluate the condition result. This allows using arbitrary custom logic to evaluate condition results.This facilitates not using schema-conditions to be able to only use one pre-compiled AJV for the data schema at a later stage.