Skip to content

refactor(core): resolve circular dependencies #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucas-koehler merged 1 commit into from
Jul 4, 2024
Merged

refactor(core): resolve circular dependencies #2345

lucas-koehler merged 1 commit into from
Jul 4, 2024

Conversation

@LukasBoll
Copy link
Contributor

@LukasBoll LukasBoll commented Jun 11, 2024

Eliminated circular dependencies in the core module and reorganized package structure.

Ref #2321

@netlify
Copy link

netlify bot commented Jun 11, 2024 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 2dc1e47
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/667fc821a084ec00086f7422
😎 Deploy Preview https://deploy-preview-2345--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jun 11, 2024

Coverage Status

coverage: 83.269% (-0.07%) from 83.337%
when pulling 0b6758f on LukasBoll:resolve_dependencies
into c00b664 on eclipsesource:master.

lucas-koehler
lucas-koehler requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LukasBoll , thanks for the PR ❤️
The changes already look mostly good to me and no more circular dependency warnings are shown :)
Besides two inline comments, I suggest renaming the folder stateToPropsMapper to simply mappers: Not all of the methods are mapping state to props but most of them map either state or dispatch to some kind of props or utility data structure.

@LukasBoll LukasBoll force-pushed the resolve_dependencies branch from 0b6758f to 6092386 Compare June 29, 2024 08:24
@LukasBoll
refactor(core): resolve circular dependencies
2dc1e47 
Eliminated circular dependencies in the core module and reorganized package structure.

Ref eclipsesource#2321
@LukasBoll LukasBoll force-pushed the resolve_dependencies branch from 6092386 to 2dc1e47 Compare June 29, 2024 08:38
@coveralls
Copy link

coveralls commented Jun 29, 2024

Coverage Status

coverage: 83.26% (-0.08%) from 83.337%
when pulling 2dc1e47 on LukasBoll:resolve_dependencies
into c3cead7 on eclipsesource:master.

@LukasBoll
Copy link
Contributor Author

LukasBoll commented Jun 29, 2024

Hi @LukasBoll , thanks for the PR ❤️ The changes already look mostly good to me and no more circular dependency warnings are shown :) Besides two inline comments, I suggest renaming the folder stateToPropsMapper to simply mappers: Not all of the methods are mapping state to props but most of them map either state or dispatch to some kind of props or utility data structure.

Hi @lucas-koehler,

Thank you for the review! I updated everything according to your suggestions!

@LukasBoll LukasBoll requested a review from lucas-koehler June 29, 2024 08:57
lucas-koehler
lucas-koehler approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @LukasBoll ! LGTM now :)

@lucas-koehler lucas-koehler linked an issue Jul 4, 2024 that may be closed by this pull request
Detect and restructure import cycles #2321
Closed
@lucas-koehler lucas-koehler merged commit 0fd6329 into eclipsesource:master Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-koehler lucas-koehler lucas-koehler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Detect and restructure import cycles

3 participants

@LukasBoll @coveralls @lucas-koehler