fix vue onChange #2084
fix vue onChange #2084
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lucas-koehler
left a comment
There was a problem hiding this comment.
The code changes look on first view. However, test test failures of the windows CI are reproducible for me on Ubuntu 22.04 and Node 14 when rebasing the PR on master.
Please rebase and check whether you can reproduce the test failures.
Test failures
1) ArrayListRenderer.vue renders children: AssertionError: expected +0 to equal 2
+ expected - actual
-0
+2
at Context.<anonymous> (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:30:1)
at processImmediate (internal/timers.js:464:21)
-
ArrayListRenderer.vue
add element to array:AssertionError: expected [ '' ] to deeply equal [ 'a', 'b', '' ]
- expected - actual
[
- "a"
- "b"
""
]
at Context. (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:37:1)
-
ArrayListRenderer.vue
remove element from array:
TypeError: Cannot read property 'trigger' of undefined
at Context. (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:43:1)
at processImmediate (internal/timers.js:464:21) -
ArrayListRenderer.vue
move element up:
TypeError: Cannot read property 'trigger' of undefined
at Context. (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:50:1)
at processImmediate (internal/timers.js:464:21) -
ArrayListRenderer.vue
move element up:
TypeError: Cannot read property 'trigger' of undefined
at Context. (dist/js/webpack:/tests/unit/array/ArrayListRenderer.spec.ts:57:1)
at processImmediate (internal/timers.js:464:21) -
BooleanControlRenderer.vue
emits a data change:AssertionError: expected true to equal false
- expected - actual
-true
+falseat Context. (dist/js/webpack:/tests/unit/controls/BooleanControlRenderer.spec.ts:31:1)
edaf204 to
bff0c8d
Compare
bff0c8d to
10737ac
Compare
converts additionalError and data to proxy closes eclipsesource#2003
10737ac to
fdb1df2
Compare
converts additionalError and data to proxy
closes #2003