Skip to content

Add bundled examples for Angular Material and Vue Vanilla #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sdirix merged 2 commits into from
Jan 25, 2023
Merged

Add bundled examples for Angular Material and Vue Vanilla #2074

sdirix merged 2 commits into from
Jan 25, 2023

Conversation

@lucas-koehler
Copy link
Contributor

@lucas-koehler lucas-koehler commented Jan 10, 2023 •
edited
Loading

  • Add rollup config to bundle the angular material example
  • Add rollup config to bundle the vue 3 vanilla example
  • Add to examples app

Notes:

Part of #1706

@netlify
Copy link

netlify bot commented Jan 10, 2023 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit acefc00
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/63beca3c364398000861631b
😎 Deploy Preview https://deploy-preview-2074--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lucas-koehler lucas-koehler mentioned this pull request Jan 10, 2023
Closed
8 tasks
@lucas-koehler
Add bundled example for Angular Material
8280881 
* Add rollup config to bundle the angular material example
* Add to examples app

Part of #1706
@lucas-koehler lucas-koehler force-pushed the lk/gh-1706/angular-example branch from bfc55b0 to 8280881 Compare January 10, 2023 17:19
@coveralls
Copy link

coveralls commented Jan 10, 2023 •
edited
Loading

Coverage Status

Coverage: 83.193%. Remained the same when pulling acefc00 on lk/gh-1706/angular-example into 36e3732 on master.

@lucas-koehler lucas-koehler requested a review from sdirix January 10, 2023 17:20
@lucas-koehler
Copy link
Contributor Author

lucas-koehler commented Jan 10, 2023

@sdirix I'm a bit confused why the deploy preview link directly links into the angular-material example. So maybe have a look if something unexpected happens here.

@lucas-koehler
Add bundled example app for Vue Vanilla
acefc00 
* Add rollup config to bundle the Vue Vanilla example
* Add to examples app

Part of #1706
@lucas-koehler lucas-koehler changed the title Add bundled example for Angular Material Add bundled examples for Angular Material and Vue Vanilla Jan 11, 2023
sdirix
sdirix approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@sdirix sdirix merged commit 1b22f55 into master Jan 25, 2023
@sdirix sdirix deleted the lk/gh-1706/angular-example branch January 25, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucas-koehler @coveralls @sdirix