Skip to content

Remove javax bundles from org.eclipse.e4.rcp Feature#745

Merged
HannesWell merged 1 commit intoeclipse-platform:masterfrom
HannesWell:removeJavaxAnnotationsFromFeature
May 8, 2023
Merged

Remove javax bundles from org.eclipse.e4.rcp Feature#745
HannesWell merged 1 commit intoeclipse-platform:masterfrom
HannesWell:removeJavaxAnnotationsFromFeature

Conversation

@HannesWell
Copy link
Copy Markdown
Member

During builds these annotation providing bundles are pulled in as transitive dependencies any ways. Removing them from this features simplifies the exchange of the atucally providing bundle and therefore the migration to Jakarta.

Part of eclipse-platform/eclipse.platform.releng.aggregator#1056

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 4, 2023

Test Results

     819 files  ±0       819 suites  ±0   45m 47s ⏱️ +58s
  5 666 tests ±0    5 523 ✔️ ±0  143 💤 ±0  0 ±0 
18 144 runs  ±0  17 691 ✔️ ±0  453 💤 ±0  0 ±0 

Results for commit be9b3bd. ± Comparison against base commit 88b7a42.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Copy Markdown
Contributor

jukzi commented May 8, 2023

LGTM

During builds these annotation providing bundles are pulled in as
transitive dependencies any ways. Removing them from this features
simplifies the exchange of the atucally providing bundle and therefore
the migration to Jakarta.

Part of eclipse-platform/eclipse.platform.releng.aggregator#1056
@HannesWell HannesWell force-pushed the removeJavaxAnnotationsFromFeature branch from 2c79115 to be9b3bd Compare May 8, 2023 20:37
@HannesWell
Copy link
Copy Markdown
Member Author

Thanks.
With eclipse-platform/eclipse.platform.releng.aggregator#1057 Tycho is configured to include sources for each bundle in the I-builds repo to that repo.
Consequently, the sources for transitively pulled in bundles are present.

@HannesWell HannesWell merged commit ce6aad3 into eclipse-platform:master May 8, 2023
@HannesWell HannesWell deleted the removeJavaxAnnotationsFromFeature branch May 8, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants