Add javax.inject/annotation providing bundles to eclipse.sdk repository#1509
Merged
HannesWell merged 1 commit intoeclipse-platform:masterfrom Nov 4, 2023
Merged
Conversation
cdd93f3 to
9e7c329
Compare
to ensure it is provided and to maintain backwards compatibility until support for javax annotations is finally removed. Part of eclipse-platform#1056
9e7c329 to
ccb7f4e
Compare
HannesWell
commented
Nov 4, 2023
Comment on lines
+49
to
+50
| <bundle id="jakarta.annotation-api" version="1.3.5"/> | ||
| <bundle id="jakarta.inject.jakarta.inject-api" version="1.0.5"/> |
Member
Author
There was a problem hiding this comment.
Sadly we cannot use version ranges here, but I assume that new versions are unlikely for those bundles anyways and the TP is in this repo too.
This was referenced Nov 4, 2023
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to ensure it is provided and to maintain backwards compatibility until support for javax annotations is finally removed.
Since eclipse-platform/eclipse.platform#792 (and two follow-ups) the
javax.inect/annotationproviding bundles are not required by theeclipse-platform-sdkanymore and therefore not part of the sdk-repo automatically.Part of #1056