Skip to content

Use version ranges to include versions jakarta.inject.jakarta.inject-api#1439

Closed
laeubi wants to merge 1 commit intoeclipse-platform:masterfrom
laeubi:use_version_range_for_jakarta.inject.jakarta.inject-api
Closed

Use version ranges to include versions jakarta.inject.jakarta.inject-api#1439
laeubi wants to merge 1 commit intoeclipse-platform:masterfrom
laeubi:use_version_range_for_jakarta.inject.jakarta.inject-api

Conversation

@laeubi
Copy link
Copy Markdown
Contributor

@laeubi laeubi commented Oct 13, 2023

@laeubi laeubi mentioned this pull request Oct 13, 2023
Merged
@akurtakov
Copy link
Copy Markdown
Member

akurtakov commented Oct 13, 2023

I've already tried locally with even hardcoded 1.x and 2.x versoins and it didn't work as only the latest version was picked. I blame

eclipse.platform.releng.aggregator/eclipse.platform.common/bundles/org.eclipse.platform.doc.isv/platformOptions.txt

Line 139 in 7594378

;${dependency.dir}/jakarta.annotation-api_*.jar
. I've even tried using full 1.x and 2.x versions there but no luck.
If one wants to test it locally, just run mvn clean verify -Declipse.javadoc=/usr/lib/jvm/java/bin/javadoc -Pbuild-individual-bundles in eclipse.platform.releng.aggregator/eclipse.platform.common/bundles/org.eclipse.platform.doc.isv (you may have to adjust the path to javadoc executable to use), after that check that target/doc.bin.log is empty - if not it will contain the errors.

@laeubi
Copy link
Copy Markdown
Contributor Author

laeubi commented Oct 13, 2023

Alright I'll try to see if I find a solution here...

@akurtakov
Copy link
Copy Markdown
Member

akurtakov commented Oct 13, 2023 •
edited
Loading

The way javadoc is produced is so error prone that it really costs multiple workdays per release to handhold it. It would be nice to get rid of the ant part and make it pure maven. Can this be covered by the IDE WG releng work ticket, @jonahgraham ?

@akurtakov
Copy link
Copy Markdown
Member

akurtakov commented Oct 13, 2023

So the issue seems to come from maven-dependency-plugin first as running mvn clean dependency:copy-dependencies old versions are not copied in target/dependencies. This is due to Maven resolving to single version.

@jonahgraham
Copy link
Copy Markdown
Contributor

jonahgraham commented Oct 13, 2023

Can this be covered by the IDE WG releng work ticket, @jonahgraham ?

I think so - @laeubi should talk to Paul Buck at EF if in doubt. My hope is that if it fits within the existing budget on the SoW then Paul says it is fine. Please feel free to cc in any email to Paul if I can help.

@akurtakov
Copy link
Copy Markdown
Member

akurtakov commented Oct 17, 2023

I'm closing this one in favor of #1449 which hardcodes versions.
@laeubi If you can work on this one to make it pure maven build without all these hacks please take it in another issue.

@akurtakov akurtakov closed this Oct 17, 2023
@laeubi
Copy link
Copy Markdown
Contributor Author

laeubi commented Oct 31, 2023

@akurtakov @jonahgraham I have now started with an initiative to get rid of more ant-magic here, of course it is only a first step and likely need enhancements and more investigations:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mickaelistria mickaelistria Awaiting requested review from mickaelistria

@akurtakov akurtakov Awaiting requested review from akurtakov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laeubi @akurtakov @jonahgraham