This repository was archived by the owner on Oct 11, 2023. It is now read-only.
Import javax.annotation with more restrictive version range#11
Merged
guw merged 1 commit intoeclipse-orbit:masterfrom May 4, 2023
Merged
Import javax.annotation with more restrictive version range#11guw merged 1 commit intoeclipse-orbit:masterfrom
guw merged 1 commit intoeclipse-orbit:masterfrom
Conversation
Required for proper resolution when jsr305 is present in same target platform. eclipse-platform/eclipse.platform.ui#738
Contributor
Author
|
@jonahgraham Is Orbit officially on GitHub now? Is it ok to merge the PR and publish a new version? |
Contributor
|
Yes, it's on GitHub. I'm not so familiar with the details but I assume it will modify what's current generated to specify upper bounds on these 3 requirements:
|
Contributor
Author
Correct. This will prevent importing (and re-exporting) the bogus JSR 305 version of the packages. |
Contributor
|
Yes, that seems good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for proper resolution when jsr305 is present in same target platform.
Fixes eclipse-platform/eclipse.platform.ui#727
eclipse-platform/eclipse.platform.ui#738