Add JMH benchmarks to jsonrpc#929
Conversation
This commit adds some basic benchmarks to serve as a starting point for future benchmarking work. On the CI we build the benchmarks, but we don't run them.
|
It is very useful to have some benchmark infrastructure like this ready to use. However regarding JMH I'd like to point out that it is GPL licensed. I once tried to add JMH benchmarks to TM4E but it was rejected by the project lead for legal concerns at the time. Maybe better check with Eclipse Legal team first. |
|
@sebthom may I ask why? Jmh is distributed under GPL v2 with classpath exception. Also adding jmh plugin does not add jmh itself to the redistributed package, so it should be fine. But I'm not a lawyer. |
|
Me neither, that was the PR eclipse-tm4e/tm4e#389 I just wanted to bring this to attention. Maybe it is not a problem after all. |
|
The IP team have previously reviewed and accepted use of JMH, ref: iplab search results - we may not be able to redistribute jmh parts, but since we don't want to do that, we are ok to proceed here. |
pisv
left a comment
There was a problem hiding this comment.
Thank you @jonahgraham for this valuable addition to the project! 👍
I have followed along with instructions in benchmarking.md and everything works as expected.
|
I have changed this to draft until I get unanimous consent or Eclipse Foundation feedback on this. See eclipse-tm4e/tm4e#389 for the ongoing discussion. |
|
Discussion in eclipse-tm4e/tm4e#389 resolved. We are all in agreement that JMH is currently OK to use. I'm going to merge this now so that dependent work can continue. |
This commit adds some basic benchmarks to serve as a starting point for future benchmarking work.
On the CI we build the benchmarks, but we don't run them.