Document LSP4J's API policy#921
Merged
Merged
Conversation
pisv
reviewed
Nov 18, 2025
pisv
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks! 👍
Assuming that breaking changes shall continue to be documented in the changelog, would it be worth it to explicitly mention it?
1ac7cd6 to
5f190eb
Compare
Contributor
Author
I changed the content of "Published API changes" section to include this information. |
Contributor
Author
|
I think this is ready to go. I will leave it for a bit in case anyone else has a comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #873
Note that I want to enforce the policy too via using
--error-on-semantic-incompatibilityfor japicmp, but that doesn't seem to be supported from CLI so I put forward siom79/japicmp#467 and if that is accepted we can automate the missing version bump detection