Fix sporadic failure of DebugIntegrationTest.testCancellation#910
Merged
Conversation
afeb5e0 to
66bed5d
Compare
Contributor
Author
|
The same problem is also present in |
Also fixes `IntegrationTest.testCancellation`, which is a twin of `DebugIntegrationTest.testCancellation` and has the same problem.
66bed5d to
b791ae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes sporadic failure of
DebugIntegrationTest.testCancellation, which happened when merging #907:https://github.com/eclipse-lsp4j/lsp4j/actions/runs/18980903518/job/54212884068
The test expected that
CancellationExceptionwould be thrown when callingfuture.getafter callingfuture.cancel, without checking thatfuture.cancelactually returnedtrue.However,
future.cancelcan also returnfalseif the future has already completed, which may happen concurrently with thefuture.cancelcall. Attempting to cancel a future is inherently racy with the future completion.In this specific case, the test should expect not only
CancellationException(whenfuture.cancelreturnstrue), but alsoExecutionExceptioncaused byResponseErrorExceptionwith message "The request (id: 1, method: 'askClient') has been cancelled" (whenfuture.cancelreturnsfalse).See also #907 (comment) and later comments in the conversation.