Skip to content

fix: ClassCastException when handling "textDocument/inlineValue" event#867

Merged
pisv merged 1 commit into
eclipse-lsp4j:mainfrom
sebthom:inlineValue
Jan 27, 2025
Merged

fix: ClassCastException when handling "textDocument/inlineValue" event#867
pisv merged 1 commit into
eclipse-lsp4j:mainfrom
sebthom:inlineValue

Conversation

@sebthom

@sebthom sebthom commented Jan 26, 2025

Copy link
Copy Markdown
Contributor

Addresses #866

@pisv pisv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 My apology for this bug, and thanks a lot for fixing it up!

@pisv pisv added this to the 0.24.0 milestone Jan 27, 2025
@pisv pisv merged commit db85990 into eclipse-lsp4j:main Jan 27, 2025
@sebthom

sebthom commented Jan 27, 2025

Copy link
Copy Markdown
Contributor Author

@pisv do you think a new lsp4j release can be created in the foreseeable future?

@pisv

pisv commented Jan 27, 2025

Copy link
Copy Markdown
Contributor

@sebthom As far as I know, #834 (comment) is the current information on this topic. If you have input on when the new release would align well with your schedule, you can comment on #834.

In the meantime, the latest integration build with the fix is available at https://download.eclipse.org/lsp4j/builds/main/.

@sebthom sebthom mentioned this pull request Jan 27, 2025
35 tasks
@sebthom sebthom deleted the inlineValue branch November 9, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClassCastException Either3 cannot be cast to InlineValue when handling "textDocument/inlineValue" event

2 participants