Update DAP protocol up to 1.65#827
Conversation
|
@jonahgraham I combined all updates into one PR. |
|
Thanks - all in one PR, but with one commit per DAP version is very helpful and should make it easier for me to review. @KamasamaK can you have a look too - is this still in your wheelhouse? |
jonahgraham
left a comment
There was a problem hiding this comment.
A quick look at this looks good, I want a second set of eyes to compare the implementation here to the spec.
Some housekeeping needs to be done before this can be merged.
The SCHEMA_VERSION in the protocol/services files needs updating, such as
And the supported version in the README needs updating:
Line 63 in 51711e1
And an entry in the changelog is needed - single line, like
Line 61 in 51711e1
|
I updated the schema version, but didn't touch other things because I don't want to interfere with the release processes. |
jonahgraham
left a comment
There was a problem hiding this comment.
Thanks @Soarex16 - This LGTM, but I did make a few small changes. Can you confirm that I didn't mess anything up.
What I changed:
- Added
Sincecomment on new fields/classes - Add "paperwork" for changelog/readme/schema version in the java code
- Added
memoryReferencetoSetExpressionResponse - Changed some wording to match what is in the upstream spec
|
@jonahgraham yes, I missed Thank you! |
|
I've finally been able to review this and found a few minor issues and one big issue that I'll address in another PR. |
No description provided.