Skip to content

update to guava 32 and orbit 2023-09#749

Merged
jonahgraham merged 4 commits into
mainfrom
cd_guavaBmp
Aug 4, 2023
Merged

update to guava 32 and orbit 2023-09#749
jonahgraham merged 4 commits into
mainfrom
cd_guavaBmp

Conversation

@cdietrich

Copy link
Copy Markdown
Contributor

update to guava 32 and orbit 2023-09

Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@cdietrich cdietrich added this to the 0.22.0 milestone Aug 3, 2023
@cdietrich cdietrich requested a review from jonahgraham August 3, 2023 19:38
Comment thread gradle/versions.gradle Outdated
Comment thread gradle/versions.gradle Outdated
@cdietrich

Copy link
Copy Markdown
Contributor Author

is there no jenkins anymore?

@jonahgraham

jonahgraham commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

is there no jenkins anymore?

Not for PRs, but for branches. It looks like it is hung though - https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/cd_guavaBmp/1/console

Comment thread releng/releng-target/lsp4j.target.target
@jonahgraham

Copy link
Copy Markdown
Contributor

is there no jenkins anymore?

Not for PRs, but for branches. It looks like it is hung though - https://ci.eclipse.org/lsp4j/job/lsp4j-multi-build/job/cd_guavaBmp/1/console

It looks like a transient Jenkins issue - job 3 worked fine and is reporting back to the here successfully.

@jonahgraham jonahgraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - before I submit I guess we need to decide about bumping min version. I applied the xtend_lib change to your branch.

@cdietrich

Copy link
Copy Markdown
Contributor Author

thx for fixing typo

Comment thread gradle/versions.gradle
@jonahgraham

Copy link
Copy Markdown
Contributor

Once this builds successfully I will merge it assuming no objections.

@jonahgraham

Copy link
Copy Markdown
Contributor

The macOS Jakarta websocket tests seem unstable. Not sure if this is a new instability, but they have failed ~25% of the time.

@jonahgraham jonahgraham merged commit a7f6419 into main Aug 4, 2023
@jonahgraham jonahgraham deleted the cd_guavaBmp branch August 4, 2023 15:57
@jonahgraham jonahgraham mentioned this pull request Aug 4, 2023
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants