Void return types need to always be null value#729
Merged
Conversation
Void type in Java cannot be instantiated, therefore if a type is declared as Void the fromJson should always set that value to null. If you want to have a generic return type that allows non-null and null results, use a type other than Void as the return type. Fixes #721
Contributor
Author
|
This has recreated #728 but in the eclipse/lsp4j repo so that we can get a p2 site out of it easily. |
Contributor
Author
Contributor
|
I tested it with the Haxe and Dart Debug Adapters and it works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Void type in Java cannot be instantiated, therefore if a type is declared as Void the fromJson should always set that value to null.
If you want to have a generic return type that allows non-null and null results, use a type other than Void as the return type.
Fixes #721