update to gson 2.10#689
Conversation
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
| 'guava_orbit': '30.1.0.v20221112-0806', | ||
| 'gson': '[2.9.1,2.10)', | ||
| 'gson_orbit': '2.9.1.v20220915-1632', | ||
| 'gson': '[2.10,2.11)', |
There was a problem hiding this comment.
| 'gson': '[2.10,2.11)', | |
| 'gson': '[2.9.1,2.11)', |
Gson 2.10 just added new methods (see eclipse-m2e/m2e-core#1146 (comment)). So if lsp4j is using gson as consumer and not as provider, the lower can actually stay where it is.
There was a problem hiding this comment.
dont know how versioning works in gson and if using upper range will pick new version in gradle and thus a new method may accidentially be used
There was a problem hiding this comment.
at least gradle build scan shows new version picked
https://scans.gradle.com/s/yudurt3xbdgie/dependencies?dependencies=gson&expandAll
am not sure if the 2.10.1 will also drop to orbit.
dont know if and when i will find time to bump
There was a problem hiding this comment.
https://git.eclipse.org/r/c/orbit/orbit-recipes/+/199278
but that one will come with m2 only
There was a problem hiding this comment.
=> propose to merge this one and then do another pr for m2
update to gson 2.10