Merged
Conversation
Kafka 4.1.x has increased the minimum segment size for topics. This change requires adjustments in the Hono ITs that create topics with custom segment sizes. Additionally, to accommodate larger message sizes, the Kafka producer configuration has been updated to allow for bigger requests.
Changed the default banner to determine the component's name, version and Hono project URL from the meta data in the POM files.
The AbstractServiceApplication has been adapted to get the component name from the Quarkus application properties instead of requiring subclasses to implement the ComponentNameProvider interface, which has been removed. Also changed the shut down hook which no longer tries to shut down the vert.x instance explicitly as Quarkus now manages its lifecycle.
Quarkus 3.27 has updated the Kafka client library to version 4.0.0 which is incompatible with vertx-kafka 4.5.22, which depends on Kafka client 3.9.1. We therefore need to explicitly depend on Kafka client 3.9.1 to ensure compatibility with vertx-kafka. This is not a problem as we do not use any Quarkus Kafka extensions directly.
debee5f to
a08666a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quarkus 3.27 has updated the Kafka client library to version 4.0.0
which is incompatible with vertx-kafka 4.5.22, which depends on Kafka
client 3.9.1.
We therefore need to explicitly depend on Kafka client 3.9.1 to
ensure compatibility with vertx-kafka. This is not a problem as
we do not use any Quarkus Kafka extensions directly.
Addresses #3722